-
Notifications
You must be signed in to change notification settings - Fork 0
Setup lightning in pipeline and local dev script #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the local development experience by automating the setup of Lightning Network channels between LND and CLN. Concurrently, it extends the client-side payments API to support new Lightning functionalities, specifically for managing and checking the status of Lightning invoices, thereby enhancing the overall Lightning integration within the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new Lightning Network functionality, both in the client API and the local development script. The API changes in paymentsApi.ts
are well-structured and consistent with the existing codebase. The ark-dev.sh
script is significantly improved with the addition of the setup_lightning_channels
function, which automates setting up a test environment. My review includes a few suggestions to make the script more robust by replacing fixed sleep
calls with polling mechanisms and improving error handling. These changes will help ensure the development setup is more reliable and deterministic.
Replace static sleep calls with more robust retry mechanisms that check LND readiness and chain sync status, providing better error handling and visibility into the startup process.
Closing in favor of this a7e8eac |
No description provided.