fix(api): end telemetry spans when middleware throws - #1012
Open
wangjingshuiku wants to merge 1 commit into
Open
fix(api): end telemetry spans when middleware throws#1012wangjingshuiku wants to merge 1 commit into
wangjingshuiku wants to merge 1 commit into
Conversation
Signed-off-by: wangjingshuiku <wangjingshuiku@163.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
End the active middleware span from a
finallyblock so it is closed on both successful requests and exceptions from downstream middleware. Return values and error propagation remain unchanged.Motivation and Context (Optional)
The previous implementation called
span.end()only afternext()resolved. Ifnext()threw, the function exited before ending the span, leaving incomplete telemetry.Validation:
pnpm --filter @blobscan/api type-checkRelated Issue (Optional)
None.
Screenshots (if appropriate):
Not applicable.