Concurrency #75
Merged
Concurrency #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyChristina
approved these changes
Jul 25, 2024
|
|
||
| # Find if some ledger files are too large to fit in the system's available memory. | ||
| too_large_ledgers = set() | ||
| for ledger in get_ledgers(): |
There was a problem hiding this comment.
I don't see why this loop is needed, can't it be done within the previous loop? (starting in L623)
| @@ -6,7 +6,7 @@ | |||
| import os | |||
| import datetime | |||
| import calendar | |||
| import argparse | |||
| import psutil | |||
There was a problem hiding this comment.
Needs to be added to requirements.txt
dimkarakostas
force-pushed
the
concurrency
branch
from
6f9ae63 to
ccb829e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description
Enables concurrency during analyzing. Adds a helper function that computes the max number of parallel processes that can run per ledger (based on the memory consumption of each ledger's largest file) and uses Python's multiprocessing to analyze snapshots with multiple parallel processes.