Skip to content

Restructure output directory #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 5, 2024
Merged

Restructure output directory #77

merged 5 commits into from
Aug 5, 2024

Conversation

dimkarakostas
Copy link
Member

All Submissions:

  • Have you followed the guidelines in our Contributing documentation?
  • Have you verified that there aren't any other open Pull Requests for the same update/change?
  • Does the Pull Request pass all tests?

Description

  • Adds check that avoids recomputing a ledger snapshot if the entry exists in the output file.
  • Organizes the output directory with one subdirectory per mapping source combination.

LadyChristina
LadyChristina approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@LadyChristina LadyChristina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing is we might want to describe this behaviour in the docs too

@dimkarakostas dimkarakostas merged commit 38fab52 into main Aug 5, 2024
1 check passed
@dimkarakostas dimkarakostas deleted the output_directory branch August 5, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadyChristina LadyChristina LadyChristina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimkarakostas @LadyChristina