Skip to content

Bump bitcoin and elements dep#137

Merged
RCasatta merged 3 commits intonew-indexfrom
bump_deps
Jan 17, 2025
Merged

Bump bitcoin and elements dep#137
RCasatta merged 3 commits intonew-indexfrom
bump_deps

Conversation

@RCasatta
Copy link
Collaborator

When building without liquid feature there are warnings to use compute_txid but by fixing those the build with the liquid feature fails because there the methods is still just txid

@shesek
Copy link
Collaborator

shesek commented Jan 14, 2025

there are warnings to use compute_txid but by fixing those the build with the liquid feature fails because there the methods is still just txid

I ran into a similar situation with deprecated methods when updating to rust-bitcoin v0.31 and ended up resolving them with some ebcompact traits that adds compatible methods to the rust-elements structs. A compute_txid->txid alias would fit there nicely.

@RCasatta
Copy link
Collaborator Author

I ran into a similar situation with deprecated methods when updating to rust-bitcoin v0.31 and ended up resolving them with some ebcompact traits that adds compatible methods to the rust-elements structs. A compute_txid->txid alias would fit there nicely.

Done in 67b465b

Copy link
Collaborator

@shesek shesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 56e03c8

@RCasatta RCasatta merged commit 21930be into new-index Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants