Fix for cargo install fail.#157
Merged
philippem merged 1 commit intoBlockstream:new-indexfrom Jul 16, 2025
Merged
Conversation
…in::secp256k1::rand even thought rand feature was enabled in bitcoin crate
0a24fd0 to
cf7c75c
Compare
Author
|
@RCasatta please review |
philippem
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
cargo installfail.randomfunction was not re-exported by bitcoin::secp256k1::rand even though rand feature was enabled in bitcoin crate and resulted in following error:but only during
cargo installrun! command to reproduce:cargo install --jobs $(nproc) --root /app/electrs_bitcoin --locked --path . --features electrum-discovery. It'e reproducible also local (not only on CI)The fix is to introduce rand crate and use its rng for random bytes generations. The project already depends on rand crate indirectly through bitcoin::secp256k1 when bitcoin rand feature is enabled (see
cargo tree -e features).