ci: check commits are GPG signed#234
Merged
apoelstra merged 1 commit intoMar 17, 2026
Merged
Conversation
672f29b to
5fc139b
Compare
Collaborator
|
Why we can not use “Require signed commits” branch protection? (can be enabled via repo setting) |
Collaborator
Contributor
|
CI is better as it will tell contributors automatically. The branch protection rule will only tell the user who wants to merge. (Both is the best) |
Collaborator
Got it, then maybe we can reuse this: https://github.com/1Password/check-signed-commits-action? |
Collaborator
|
So instead of the custom script, we do it like follows: |
Contributor
|
I mildly prefer the custom script. We don't need to worry about supply chain issues and updates and old versions being deleted, and it will be less hassle if/when we move off of Github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a new workflow to check that commits are GPG signed as required for merging