Skip to content

ci: check commits are GPG signed#234

Merged
apoelstra merged 1 commit into
BlockstreamResearch:masterfrom
delta1:ci/check-signed-commits
Mar 17, 2026
Merged

ci: check commits are GPG signed#234
apoelstra merged 1 commit into
BlockstreamResearch:masterfrom
delta1:ci/check-signed-commits

Conversation

@delta1

@delta1 delta1 commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

Adds a new workflow to check that commits are GPG signed as required for merging

@delta1 delta1 force-pushed the ci/check-signed-commits branch from 672f29b to 5fc139b Compare March 13, 2026 09:01
@KyrylR

KyrylR commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

Why we can not use “Require signed commits” branch protection? (can be enabled via repo setting)

@KyrylR

KyrylR commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator
image It looks like it is already enabled

@stringhandler

Copy link
Copy Markdown
Contributor

CI is better as it will tell contributors automatically. The branch protection rule will only tell the user who wants to merge. (Both is the best)

@KyrylR

KyrylR commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

CI is better as it will tell contributors automatically. The branch protection rule will only tell the user who wants to merge. (Both is the best)

Got it, then maybe we can reuse this: https://github.com/1Password/check-signed-commits-action?

@KyrylR

KyrylR commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

So instead of the custom script, we do it like follows:

name: Check signed commits in PR 
on: pull_request_target

jobs:
  check-signed-commits:
    name: Check signed commits in PR
    runs-on: ubuntu-latest
    permissions:
      contents: read
      pull-requests: write
    steps:
      - name: Check signed commits in PR
        uses: 1Password/check-signed-commits-action@v1

@apoelstra

Copy link
Copy Markdown
Contributor

I mildly prefer the custom script. We don't need to worry about supply chain issues and updates and old versions being deleted, and it will be less hassle if/when we move off of Github.

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5fc139b; successfully ran local tests

@apoelstra apoelstra merged commit ec02ac8 into BlockstreamResearch:master Mar 17, 2026
11 checks passed
@delta1 delta1 deleted the ci/check-signed-commits branch March 17, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants