feat: unstable with traits#354
Merged
KyrylR merged 4 commits intoJun 25, 2026
Merged
Conversation
LesterEvSe
requested changes
Jun 11, 2026
Sdoba16
force-pushed
the
feature/unstable-with-traits
branch
3 times, most recently
from
af5f7dc to
2ddec75
Compare
LesterEvSe
requested changes
Jun 23, 2026
Sdoba16
force-pushed
the
feature/unstable-with-traits
branch
from
2ddec75 to
dbe633b
Compare
LesterEvSe
approved these changes
Jun 23, 2026
LesterEvSe
left a comment
LesterEvSe
left a comment
Collaborator
There was a problem hiding this comment.
ACK dbe633b; tested locally
LesterEvSe
force-pushed
the
feature/unstable-with-traits
branch
4 times, most recently
from
3cf3675 to
16b3674
Compare
Collaborator
|
Note that once this PR is merged, we will need to update Simplex to support the new unstable features. |
LesterEvSe
force-pushed
the
feature/unstable-with-traits
branch
from
16b3674 to
131cc53
Compare
Contributor
|
131cc53 needs rebase |
LesterEvSe
force-pushed
the
feature/unstable-with-traits
branch
2 times, most recently
from
f2429cc to
1a06f35
Compare
LesterEvSe
force-pushed
the
feature/unstable-with-traits
branch
from
1a06f35 to
b8d2b34
Compare
LesterEvSe
added a commit
that referenced
this pull request
Jun 26, 2026
66d20b5 remove leftover commented code from `lib.rs` (LesterEvSe) Pull request description: This PR removes commented-out code blocks in `lib.rs` that were inadvertently left behind during the unstable features merge #354 ACKs for top commit: KyrylR: utACK 66d20b5 Tree-SHA512: 9ccf7ce25b3d9a0749942b0f5bc0c64237dc5f0a9aad2cfa279488ddfae8439691164db5a94bab5af8e00ddb269e274020608efb34d78c8ccabe7eb047b2538b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #317
Replaces #329
Added
UnstableFeatureenum to track available unstable featuresAdded
UnstableFeaturesto check whether a feature is enabledAdded
RequireFeaturetrait, implemented for every AST node. Each node reports which unstable features it requires. Struct impls use full field destructuring and enum impls use exhaustive matches, so new nodes or fields cause a compile error until the impl is updated.The check runs at parse time: once a program parses without errors, any use of a disabled feature is reported with an error naming the feature and the
-Zflag that enables it.Added a
-Z <feature>flag to the CLI. Multiple features can be passed with repeated flags. Available features are listed in the help output.simc program.simf -Z importsAdded
doc/unstable-features.mdwith user and developer guides.