Fix command builder whitespace handling #2018
Open
+80
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcpro1
force-pushed
the
fix-command-builder-whitespace
branch
from
fa92994 to
b2f2d86
Compare
Add a seprate command for parameters that need to be split on whitespace boundaries, and default to not splitting. The previous behaviour always split parameters, which caused copilot CLI to fail when a project had whitespace in the repository directory name; `error: too many arguments. Expected 0 arguments but got 1;. The issue was not specific to copilot altough it only occured in copilot due to an implementation detail for copilot where it recevied a directory name which happened to contain the project name.
abcpro1
force-pushed
the
fix-command-builder-whitespace
branch
from
b2f2d86 to
4f61db7
Compare
Contributor
|
!reviewfast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate command for parameters that need to be split on whitespace boundaries, and default to not splitting.
The previous behaviour always split parameters, which caused copilot CLI to fail when a project had whitespace in the repository directory name;
error: too many arguments. Expected 0 arguments but got 1.Even though it only happened in Copilot because of an implementation detail where it received a directory name that also happened to contain the project name, the problem was not unique to Copilot.