-
Notifications
You must be signed in to change notification settings - Fork 185
Add option to hide title bar on linux #2951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: joel/1.15/desktop/1.15.5.0
Are you sure you want to change the base?
Add option to hide title bar on linux #2951
Conversation
…desktop/1.15.2.0 Fix issues when app is packaged as MSIX
…desktop/1.15.4.0 Desktop 1.15.4.0
|
Also, what's the use case for this? |
Looks like they're on a tiling window manager, where no apps have title bars. Instead, keyboard shortcuts are used to manage windows. BlueBubbles would most likely be the only app that still has a bar in this scenario. |
|
Sorry I missed this! Yeah, the use case is tiling window managers where application titlebars are hidden and the compositor provides its own minimal decorations. In these setups, the compositor can advertise a preference for server‑side decorations and inform clients that they are tiled, but Flutter/bitsdojo_window currently forces client‑side decorations in native mode and does not obey that hint. For example, on my system all window control buttons are disabled; with useCustomTitlebar off, bitsdojo_window still reserves and draws an empty titlebar area above the app content (the left image). A "hidden" option for the titlebar lets the app surface be fully decoration‑less so the compositor’s own decorations can be the only visible ones, which is the expected behavior on tiling WMs. |
jjoelj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor UX thing
| s.pinColumnsLandscape.value = map['pinColumnsLandscape'] ?? 4; | ||
| s.maxAvatarsInGroupWidget.value = map['maxAvatarsInGroupWidget'] ?? 4; | ||
| s.useCustomTitleBar.value = map['useCustomTitleBar'] ?? true; | ||
| s.titleBarStyle.value = map['titleBarStyle'] != null ? BBTitleBarStyle.values[map['titleBarStyle']] : BBTitleBarStyle.custom; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a migration here from useCustomTitleBar to titleBarStyle similar to what we do with useDesktopAccent (when we changed the name from useWindowsAccent)? Otherwise, the update will change the settings for the user in an unexpected way.
This PR adds the ability to complete hide the title bar on linux. This replaces the Use Custom TitleBar option with a TitleBar Style selection with the following options: