840 feature request add first steel check to blueprints #841
Conversation
…t tests for validation
…er-for-concrete-steel-more-and
…lass-with-coordinate-system-for-all-strenthstability-checks
…er-for-concrete-steel-more-and
…lass-with-coordinate-system-for-all-strenthstability-checks
…7-1+C2:2017 such that it will allign with next commit
…1D class and tests, remove LoadCombination class and related tests
…oordinate-system-for-all-strenthstability-checks' of https://github.com/Blueprints-org/blueprints into 831-feature-request-define-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks
…the coordinate system
…eperate-checks-folder-for-concrete-steel-more-and Initiate seperatation of checks folder into multiple folders.
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the nominal concrete cover check by moving it into a material-specific folder structure (concrete) and adds a new steel check capability to the blueprints system. The changes update import paths throughout the codebase to reflect the new location of the concrete check module.
Key changes:
- Restructured checks folder to organize by material type (concrete)
- Updated import paths from
blueprints.checks.nominal_concrete_covertoblueprints.checks.concrete.nominal_concrete_cover - Added new
__init__.pyfiles to support the reorganized structure
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/checks/concrete/nominal_concrete_cover/test_nominal_concrete_cover.py |
Updated import path to reference concrete-specific module location |
tests/checks/concrete/__init__.py |
Added new init file with docstring for concrete test checks |
tests/checks/__init__.py |
Updated docstring capitalization for consistency |
docs/examples/other_examples/nominal_concrete_cover.ipynb |
Updated import path in documentation example to match new structure |
blueprints/checks/concrete/__init__.py |
Added new init file with docstring for concrete checks module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 402 404 +2
Lines 12602 12643 +41
=========================================
+ Hits 12602 12643 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…, add ResultInternalForce1D with updated structure and validation
…' into 831-feature-request-define-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks
…e-loadcombination-class-with-coordinate-system-for-all-strenthstability-checks 831 feature request define internal forces class with coordinate system for all strength and stability checks
…dd-first-steel-check-to-blueprints
…' into 837-feature-request-add-latex-option-for-intermediate-results
…in formulas 6.5 and 6.9
…atex-option-for-intermediate-results 837 feature request add latex option for intermediate results
Description
Feature request add first steel check to blueprints
Fixes #840
Type of change
Please delete options that are not relevant.
Checklist: