-
Notifications
You must be signed in to change notification settings - Fork 19
Remove unused _evaluate and __bool__ methods from Form5Dot17CompressionCheckZProfilesClass1And2 class #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused _evaluate and __bool__ methods from Form5Dot17CompressionCheckZProfilesClass1And2 class #911
Conversation
…onCheckZProfilesClass1And2 class
|
Thank you so much for contributing to Blueprints! Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes unused _evaluate and __bool__ methods from the Form5Dot17CompressionCheckZProfilesClass1And2 class. These methods are likely redundant since the class inherits from ComparisonFormula which should provide standard comparison functionality through its base implementation.
- Removed the static
_evaluatemethod that performed the comparison check - Removed the
__bool__method that enabled truth-checking of instances
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughRemoved two methods ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks✅ Passed checks (5 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 404 404
Lines 12798 12798
=========================================
Hits 12798 12798 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rom-comparsion-prompt
…rom-comparsion-prompt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Remove unused _evaluate and bool methods from Form5Dot17CompressionCheckZProfilesClass1And2 class
Fixes #910
Type of change
Please delete options that are not relevant.
Checklist:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.