fix: stricter type hints for service decorators#549
Merged
Conversation
Make strict type checkers happier by adding more precise type hints to the `dbus_method`, `dbus_signal` and `dbus_property` decorators. Also improve internal type hints in the file while we're at it. This is mostly adding generic parameters to types that expect them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 85.25% 85.26%
=======================================
Files 28 28
Lines 3431 3433 +2
Branches 601 601
=======================================
+ Hits 2925 2927 +2
Misses 313 313
Partials 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #549 will not alter performanceComparing Summary
|
bdraco
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make strict type checkers happier by adding more precise type hints to the
dbus_method,dbus_signalanddbus_propertydecorators.Also improve internal type hints in the file while we're at it. This is mostly adding generic parameters to types that expect them.