Skip to content

fix: stricter type hints for service decorators#549

Merged
dlech merged 3 commits intomainfrom
decorator-type-hints
Nov 17, 2025
Merged

fix: stricter type hints for service decorators#549
dlech merged 3 commits intomainfrom
decorator-type-hints

Conversation

@dlech
Copy link
Member

@dlech dlech commented Nov 17, 2025

Make strict type checkers happier by adding more precise type hints to the dbus_method, dbus_signal and dbus_property decorators.

Also improve internal type hints in the file while we're at it. This is mostly adding generic parameters to types that expect them.

dlech and others added 2 commits November 16, 2025 18:36
Make strict type checkers happier by adding more precise type hints
to the `dbus_method`, `dbus_signal` and `dbus_property` decorators.

Also improve internal type hints in the file while we're at it. This is
mostly adding generic parameters to types that expect them.
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.26%. Comparing base (9aa8f56) to head (71fed27).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   85.25%   85.26%           
=======================================
  Files          28       28           
  Lines        3431     3433    +2     
  Branches      601      601           
=======================================
+ Hits         2925     2927    +2     
  Misses        313      313           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025

CodSpeed Performance Report

Merging #549 will not alter performance

Comparing decorator-type-hints (71fed27) with main (9aa8f56)

Summary

✅ 6 untouched

@dlech dlech merged commit b967cce into main Nov 17, 2025
24 checks passed
@dlech dlech deleted the decorator-type-hints branch November 17, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments