Skip to content

fix: fix service getter/setter tasks tracking#550

Merged
dlech merged 2 commits intomainfrom
fix-service-property-tasks
Nov 17, 2025
Merged

fix: fix service getter/setter tasks tracking#550
dlech merged 2 commits intomainfrom
fix-service-property-tasks

Conversation

@dlech
Copy link
Member

@dlech dlech commented Nov 17, 2025

Keep a handle to asyncio tasks created for service async property getters and setters to prevent them from being garbage collected before they complete.

dlech and others added 2 commits November 16, 2025 18:47
Keep a handle to asyncio tasks created for service async property
getters and setters to prevent them from being garbage collected
before they complete.
@dlech
Copy link
Member Author

dlech commented Nov 17, 2025

Just happened to notice this one while looking at the type hints.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (ea93352) to head (7ad0599).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   85.23%   85.13%   -0.10%     
==========================================
  Files          28       28              
  Lines        3426     3431       +5     
  Branches      601      601              
==========================================
+ Hits         2920     2921       +1     
- Misses        313      317       +4     
  Partials      193      193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025

CodSpeed Performance Report

Merging #550 will not alter performance

Comparing fix-service-property-tasks (7ad0599) with main (ea93352)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (f368714) during the generation of this report, so ea93352 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@dlech dlech merged commit 9aa8f56 into main Nov 17, 2025
23 of 24 checks passed
@dlech dlech deleted the fix-service-property-tasks branch November 17, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments