Skip to content

#271640 [dv.edish] Feature requests - User-controlled axes ranges#14

Merged
luffmark merged 33 commits into
testfrom
271640-axes-range
May 13, 2025
Merged

#271640 [dv.edish] Feature requests - User-controlled axes ranges#14
luffmark merged 33 commits into
testfrom
271640-axes-range

Conversation

@luffmark
Copy link
Copy Markdown
Contributor

@luffmark luffmark commented Apr 23, 2025

Critical checks

  • Is the version number correct?

    • DESCRIPTION file

    • NEWS.md

  • Does the build pass?


Documentation

Does it include the following sections?

  • Module introduction with features

    • (O) Screenshots
  • Installation details

  • Explanation of function arguments

  • Data specifications and requirements

  • Different possible visualizations

  • Are the changes/new features included in NEWS.md?

  • (O) Screenshots

  • (O) Explanation of input menus

  • (O) Short articles on building the app, compatibility with other modules, known bugs,...


QC Report

  • Does it include a QC Report with positive outcome?

  • Are the new features reflected accordingly in the specs?


API conventions

  • Follows API convention

@luffmark luffmark requested a review from a team as a code owner April 23, 2025 11:21
@luffmark luffmark marked this pull request as draft May 1, 2025 08:51
@luffmark luffmark self-assigned this May 6, 2025
@luffmark luffmark marked this pull request as ready for review May 6, 2025 09:31
@zsigmas zsigmas self-requested a review May 6, 2025 10:50
Copy link
Copy Markdown

@zsigmas zsigmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just those two doubts. Thanks @luffmark !

Comment thread R/helper_functions.R
Comment thread R/helper_functions.R
Comment thread R/mod_edish.R Outdated
Copy link
Copy Markdown
Contributor

@iglauss iglauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my end! Thank you so much.

@luffmark luffmark merged commit ec033d5 into test May 13, 2025
5 checks passed
@luffmark luffmark deleted the 271640-axes-range branch May 13, 2025 09:21
luffmark added a commit that referenced this pull request Jun 11, 2025
* Update shared code snippets.

* Update shared code snippet.

* #271640 [dv.edish] Feature requests - User-controlled axes ranges (#14)

* Update version number to 1.2.0

---------

Co-authored-by: zxBIB Lechón,Miguel (MED BDS) EXTERNAL <miguel.lechon.ext@boehringer-ingelheim.com>
Co-authored-by: ml-ebs-ext <157474668+ml-ebs-ext@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants