Skip to content

Conversation

@gm-ebs-ext
Copy link
Contributor

No description provided.

@gm-ebs-ext gm-ebs-ext requested a review from a team as a code owner March 17, 2025 09:46
@ml-ebs-ext
Copy link
Collaborator

For anyone else lookint at this PR, here's how the error message looks like when a subject is missing the trt_start_date value:
image

I'm OK with the changes. Maybe the feedback would be more actionable if the messages mentioned also the name of the affected dataset (available in the subject_level_dataset_name argument to check_papo_call). Could you add that, @gm-ebs-ext?

I think I may be holding these new error messages to a higher standard than the pre-existing dv.papo messages because we've iterated quite a bit on the early error feedback user-friendliness in our other packages. Sorry for nitpicking!

@gm-ebs-ext gm-ebs-ext merged commit 356a1f7 into test Mar 17, 2025
5 checks passed
@gm-ebs-ext gm-ebs-ext deleted the 257249_missing_trt_start_date branch March 31, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants