240329 align papo clinline date inputs#21
Closed
gm-ebs-ext wants to merge 5 commits into
Closed
Conversation
Collaborator
|
This single-line change is an improvement, but the ICF variable is not the only one that leads to the "blank timeline" problem. I personally would favor an alternative approach, which can be summarized as:
This would take care of the whole family of errors in a single place. There is already something similar in this codebase ( This exercise would be easier in any of our other codebases, because they have a second-generation module wrapper, so I think a good prior step would be to move this codebase to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.