fix yn mapping #40
Merged
fix yn mapping #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`class` and `levels` attributes were being assigned in a`non-factor` object. We were trying to keep all attributes to make the minimal set of changes during mapping.
Contributor
|
Approach looks good to me! Thanks, @zsigmas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classandlevelsattributes were being assigned in anon-factorobject. We were trying to keep all attributes to make the minimal set of changes during mapping.If we like the approach tests should be included.
Hotfix checklist
Bumped minor version number on both DESCRIPTION and NEWS.md
Build passes pipeline checks
The new changes do not affect the API
The new changes do not affect the documentation (including screenshots)
The new changes do not impact the QC report
Tests covering the bug has been included