Merge test to main #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial GitHub release
Add validation to ensure results dataset is not empty
iglauss
reviewed
Nov 10, 2025
There was a problem hiding this comment.
Looks very good! Only one questions, see comments.
Stable Release
- Update the version number and make sure -9000 suffix is removed.
- Merge all NEWS under a single version entry
- Integration tests pass
- devtools::document() is up to date
- devtools::check() runs internally
DESCRIPTION
Outdated
| RoxygenNote: 7.3.2 | ||
| Remotes: | ||
| Boehringer-Ingelheim/dv.manager@main, | ||
| Boehringer-Ingelheim/dv.papo@main |
There was a problem hiding this comment.
@mingstat Why do we list dv.papo here under "Remotes"? I cannot remember that we did this for other modules that are able to jump to papo. Does this create any benefit?
Contributor
Author
There was a problem hiding this comment.
The dv.papo dependency is optional. For consistency with other modules, I’ve removed it from DESCRIPTION to keep the dependency list clean.
iglauss
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.