Skip to content

Dev to test#2

Merged
mingstat merged 22 commits into
testfrom
dev
Mar 17, 2026
Merged

Dev to test#2
mingstat merged 22 commits into
testfrom
dev

Conversation

@mingstat
Copy link
Copy Markdown
Contributor

No description provided.

@mingstat mingstat requested a review from typoumet February 24, 2026 08:24
@mingstat mingstat requested a review from a team as a code owner February 24, 2026 08:24
Copy link
Copy Markdown

@typoumet typoumet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a number of comments for your consideration.

Comment thread man/mod_swimmerplot.Rd Outdated
result_tooltip_vars = NULL,
trt_annotation_vars = NULL,
trt_annotation_x = NULL,
result_annotation_vars = NULL,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread man/mod_swimmerplot.Rd Outdated
\item{trt_annotation_x}{`[numeric(1)]` X-axis position for a left-aligned fixed exposure annotation column.
If NULL, the exposure annotation is placed after each exposure bar end.}

\item{result_annotation_vars}{`[character(n)]` Character vector of variables for fixed text annotation on response points.}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread man/swimmerplot.Rd Outdated
x_rng_upper = NULL,
trt_annotation_vars = NULL,
trt_annotation_x = NULL,
result_annotation_vars = NULL,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread man/swimmerplot.Rd Outdated
\item{trt_annotation_x}{`[numeric(1)]` X-axis position for a left-aligned fixed exposure annotation column.
If NULL, the exposure annotation is placed after each exposure bar end.}

\item{result_annotation_vars}{`[character(n)]` Character vector of variables for fixed text annotation on response points.}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread man/swimmerplot_server.Rd Outdated
result_tooltip_vars = NULL,
trt_annotation_vars = NULL,
trt_annotation_x = NULL,
result_annotation_vars = NULL,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread R/mod_swimmerplot.R Outdated
result_tooltip_vars = result_tooltip_vars,
trt_annotation_vars = trt_annotation_vars,
trt_annotation_x = trt_annotation_x,
result_annotation_vars = result_annotation_vars,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread R/mod_swimmerplot.R Outdated
#' @param trt_annotation_vars `[character(n)]` Character vector of variables for fixed text annotation on exposure.
#' @param trt_annotation_x `[numeric(1)]` X-axis position for a left-aligned fixed exposure annotation column.
#' If NULL, the exposure annotation is placed after each exposure bar end.
#' @param result_annotation_vars `[character(n)]` Character vector of variables for fixed text annotation on response points.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread R/mod_swimmerplot.R Outdated
result_tooltip_vars = NULL,
trt_annotation_vars = NULL,
trt_annotation_x = NULL,
result_annotation_vars = NULL,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread R/mod_swimmerplot.R Outdated
checkmate::assert_character(result_tooltip_vars, null.ok = TRUE)
checkmate::assert_character(trt_annotation_vars, null.ok = TRUE)
checkmate::assert_number(trt_annotation_x, null.ok = TRUE)
checkmate::assert_character(result_annotation_vars, null.ok = TRUE)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

Comment thread R/mod_swimmerplot.R Outdated
result_tooltip_vars = result_tooltip_vars,
trt_annotation_vars = trt_annotation_vars,
trt_annotation_x = trt_annotation_x,
result_annotation_vars = result_annotation_vars,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Ming, this argument is no longer required, and it should be removed.

@mingstat
Copy link
Copy Markdown
Contributor Author

As suggested, the result_annotation_vars argument and the feature for adding point annotations have been removed. The dependency on the ggforce package has also been removed.

Comment thread R/mod_swimmerplot.R
@mingstat mingstat merged commit cb52da6 into test Mar 17, 2026
10 checks passed
@mingstat mingstat deleted the dev branch March 17, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants