Skip to content

Migrate repository to typescript#110

Open
matzehecht wants to merge 6 commits into
nextfrom
feature/typescript-migration
Open

Migrate repository to typescript#110
matzehecht wants to merge 6 commits into
nextfrom
feature/typescript-migration

Conversation

@matzehecht
Copy link
Copy Markdown
Contributor

No description provided.

@matzehecht matzehecht requested review from ElfenB and SimonGolms May 13, 2026 16:36
@matzehecht matzehecht self-assigned this May 13, 2026
by switching to tsdown
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 9.5.0-typescript-migration.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 9.5.0-typescript-migration.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matzehecht matzehecht marked this pull request as ready for review May 13, 2026 17:52
Comment thread src/configs/react.ts Outdated
},
},
plugins: {
// @ts-expect-error -- This is as per documentation of eslint-plugin-react, see: https://www.npmjs.com/package/eslint-plugin-react-hooks
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything about this ts-exception in the link provided

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link does not show the ts-exception, but shows that the configuration here is according to the docs (but it still throws an error here, so there must be some typing issues)

Comment thread src/configs/strict.ts Outdated
Comment thread package.json Outdated
Comment thread package.json
}
"semantic-release": "25.0.2",
"tsdown": "^0.22.0",
"typescript": "^5.9.3"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump the ts version to 6+?
We should probably not introduce a new feature with an old version ...

Copy link
Copy Markdown
Contributor Author

@matzehecht matzehecht May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS 6 will cause a dependency version conflicts with the @typescript-eslint/* packages. I would like to do the dependency updates on a separate branch/PR. This PR only merges to next, so there should not be any release with the legacy version. Fine for you?

Comment thread tsconfig.json Outdated
Hecht,Matthias (IT EDP) BIG-DE-B added 2 commits May 18, 2026 11:48
tsdown bundled some dependencies and caused other small issues. switching back for reliance
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 9.5.0-typescript-migration.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants