Skip to content

new condition class#79

Merged
saumil-sh merged 4 commits into
mainfrom
dev_condition
May 6, 2026
Merged

new condition class#79
saumil-sh merged 4 commits into
mainfrom
dev_condition

Conversation

@mvalkobi
Copy link
Copy Markdown
Contributor

@mvalkobi mvalkobi commented Apr 8, 2026

Resolves #67 #80 #81

Broke out the condition statement

  1. trial now runs a loop over the condition list as it takes an argument
  2. Timer no longer tasks the condition list
  3. Condition list is now an object. All searching over via loops is removed and so does the add_condition function. No longer is needed and can be done by the constructor.
    This will make testing new conditions much more simple going forward.

Documentation is not finalized and will be post review of design.

@saumil-sh
Copy link
Copy Markdown
Collaborator

The pkgdown ci is failing due to pak. I cannot reproduce this locally.

Copy link
Copy Markdown
Contributor Author

@mvalkobi mvalkobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@saumil-sh saumil-sh requested a review from mitchell-thomann May 6, 2026 06:51
@saumil-sh saumil-sh merged commit 7b30e4e into main May 6, 2026
2 checks passed
@saumil-sh saumil-sh deleted the dev_condition branch May 6, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Condition need their own new class

2 participants