Skip to content

Conversation

@tefra
Copy link

@tefra tefra commented Aug 11, 2025

Modified the exception handling in worker to include full traceback information for ConnectionError.

Resolves #756

Copy link
Collaborator

@LincolnPuzey LincolnPuzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, thanks

@LincolnPuzey
Copy link
Collaborator

Actually after testing this, I am not in favor of adding the traceback.

Because it makes the logs from connection errors a lot noisier, and gives the impression of a bug in dramatiq, when connection errors are in fact known/expected errors.
Because starting dramatiq with no broker service running, is a likely scenario for a beginner, we want to avoid this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Traceback Logging for ConnectionError in Worker

2 participants