cookbook recipe for lazy init with sub broker #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardogsilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cookbook recipe showing how to integrate dramatiq when using a factory function application pattern.
This is something which has been discussed in some issues in the past, for example:
It seems supporting this use case is not part of dramatiq's design, but it is something which would be beneficial to have as a cookbook entry.
The approach proposed in this PR is different from the ones mentioned in the aforementioned issues. It boils down to using a
StubBrokeras the initial broker, to which tasks are registered. This means that at import time, the stub broker is being used and causes no eager connection attempts.Then the stub broker is replaced by the real worker inside the application factory function, after the actual broker settings are already known.