redis: Remove worker heartbeat compatibility code #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeroll
force-pushed
the
remove-heartbeat-compat
branch
from
8ce7b51 to
2df7e7c
Compare
mikeroll
changed the title
Collaborator
|
@mikeroll Can you split removing the Broker args into its own PR? I am happy to merge that. Removing the other compat code might need more discussion. Thanks |
mikeroll
force-pushed
the
remove-heartbeat-compat
branch
from
2df7e7c to
68b8105
Compare
Contributor
Author
|
@LincolnPuzey you are right, these two are somewhat different issues. I've split the args out into #782 |
mikeroll
force-pushed
the
remove-heartbeat-compat
branch
from
68b8105 to
4788bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit d6cff30.
The heartbeat logic had been changed in v1.2.0, so removing this is a breaking change only for those who would be upgrading from v1.1.0 - which released more than 7 years ago - directly to v2.
Closes #770