Skip to content

Fix #795: Incorrect typing with async decorators #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+18 −2
Open

Fix #795: Incorrect typing with async decorators #796

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85ece1c
Fix #795: Incorrect typing with async decorators
janek-cosmose Nov 27, 2025
442a503
fix - add Protocol
janek-cosmose Nov 27, 2025
51abede
reorder protocol overloads
janek-cosmose Nov 27, 2025
13fb48d
fix
janek-cosmose Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions dramatiq/actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
Generic,
Optional,
ParamSpec,
Protocol,
TypeVar,
Union,
overload,
Expand Down Expand Up @@ -202,13 +203,28 @@ def __str__(self) -> str:
return "Actor(%(actor_name)s)" % vars(self)


class ActorDecorator(Protocol):
@overload
def __call__(self, fn: Callable[P, Awaitable[R]]) -> Actor[P, R]: ...

@overload
def __call__(self, fn: Callable[P, R]) -> Actor[P, R]: ...

def __call__(self, fn: Callable[P, Union[Awaitable[R], R]]) -> Actor[P, R]: ...


@overload
def actor(fn: Callable[P, Awaitable[R]], **kwargs) -> Actor[P, R]:
pass


@overload
def actor(fn: Callable[P, Union[Awaitable[R], R]], **kwargs) -> Actor[P, R]:
def actor(fn: Callable[P, R], **kwargs) -> Actor[P, R]:
pass


@overload
def actor(fn: None = None, **kwargs) -> Callable[[Callable[P, Union[Awaitable[R], R]]], Actor[P, R]]:
def actor(fn: None = None, **kwargs) -> ActorDecorator:
pass


Expand Down