Fix AsyncIO middleware keeping local references in traceback #802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While investigating a memory leak in polar, we found out that exceptions raised inside async actors lead to local references being held until worker shutdown.
When a coroutine raises an exception:
Futurecaptures the exception with its full tracebackDemo script showing the issue
Fix
Added an
after_process_messagehook to theAsyncIOmiddleware that clearsexception.__traceback__. This runs after the worker logs the exception (so stack traces are preserved for debugging) but before references can accumulate.