Fixes to type hints for @actor decorator and Actor class
#804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes mypy with the current code.
…n type is returned
LincolnPuzey
force-pushed
the
more_actor_type_fixes
branch
from
f53fcf9 to
9c1e378
Compare
LincolnPuzey
changed the title
@actor decorator and Actor class type hints
LincolnPuzey
changed the title
@actor decorator and Actor class type hints@actor decorator and Actor class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR only changes type hints and tests. No runtime changes.
Follow on from #796
Main fixes are
Actor.__call__now returns correct type. Which isR- The return type for the function.@actor()decorator with kwargs, type hints are now provided for the kwargs.fnandkwargsto be provided to the@actor. Should be one or the other.