Bugfix: Change logic of completed_count property for group #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LincolnPuzey
requested changes
Jan 6, 2026
Collaborator
LincolnPuzey
left a comment
LincolnPuzey
left a comment
There was a problem hiding this comment.
Thanks @ABolouk
Can you
- Add yourself to the
CONTRIBUTORSfile. - Revert the changes to the
pipelineclass. Because a pipeline processes messages in order, I don't think there is any bug there.
LincolnPuzey
changed the title
Add test for for when the jobs in a group finish out of order.
LincolnPuzey
approved these changes
Jan 6, 2026
Collaborator
LincolnPuzey
left a comment
LincolnPuzey
left a comment
There was a problem hiding this comment.
Thanks again! I've added a regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #452