Add a files pattern to the JS linter #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: I tried writing a test for this, but it quickly became complex, as non-supported files seem to be ignored as long as there isn’t a plugin for adding language support - so, testing if CSS files are ignored via a pattern doesn’t matter unless we include a plugin to enable CSS support in the test suite, which quickly became a bit of a hassle... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
files-pattern represented as**/*.jsto the js.js config file, and exposed that as the jsConfig choice rather thanbaseConfig.This prevents a situation where eslint 9.6+ is used for linting other languages, and then fails due to the
baseConfigassuming that all files are JS by default. Potentially a breaking change? Not sure.