[BMOL-28] POST v1/oneliner 구현 #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokers
reviewed
May 29, 2023
src/services/onelinerService.js
Outdated
| return this._serviceName | ||
| } | ||
|
|
||
| async postOneliner(userId, book_id, title, authors, oneliner, color, top, left, font, font_size, bg_image_url){ |
There was a problem hiding this comment.
parameter 의 validation 체크가 없네요
Comment on lines
22
to
31
| const result = await onelinerService.postOneliner(userId, book_id, | ||
| title, | ||
| authors, | ||
| oneliner, | ||
| color, | ||
| top, | ||
| left, | ||
| font, | ||
| font_size, | ||
| bg_image_url); |
There was a problem hiding this comment.
이렇게 함수 parameter가 많은경우 object로 묶어서 전달하는게 좋아요
const result = await onelinerService.postOneliner({userId, book_id, title, authors, oneliner, color, top, left, font, font_size, bg_image_url});
…eliner에서 parameters를 object로 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BMOL-27 오늘 한줄 등록 기능입니다.
Jira: https://bookmarkoneliner.atlassian.net/browse/BMOL-28
Postman API 문서: https://documenter.getpostman.com/view/24386698/2s93m8xKfC