-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tray icon to show up to 10 recently updated notes #3104
Open
AWolf81
wants to merge
11
commits into
BoostIO:master
Choose a base branch
from
AWolf81:tray
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+129
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # browser/main/Main.js # browser/main/NoteList/index.js # browser/main/modals/PreferencesModal/UiTab.js # lib/main-window.js
I'll check macOS |
OK, I've updated this and tested it again. The only thing I've noticed is that the link menu is just showing on right-click. Tested on Windows. I have to check how it's working in Linux. |
I'll also check this in this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's based on PR #1536. Once this is ready we can close the other PR.
I've changed menu creation so it is showing the 10 recently updated notes across all storage location and added a filter for an empty title as I think we don't want to show blank lines in the tray or should we handle this differently?
Notes from my review of other PR:
Todos:
Initial loading of recent notes seems to be not working but it's just a click issue. Left mouse won't show recent notes but right mouse click works correctly. Ideally left & right should display the same menu (if possible) I think it's OK to have it only on right click. Not found a fix as Electron is problematic to handle the tray clicks properly - tried to add
right-click
handler but with-out successFilter trashed notes from the tray menu as link click for deleted items wasn't working properly.
Linux Mint issues (skipped Mint testing as I have troubles with my VM ware image. Ubuntu is working)
OS tests
Windows 10
Linux (I will check Ubuntu & Linux Mint)
MacOs (I need support here as I don't have access to a Mac)
Type of changes
Checklist:
Screenshots
Windows 10

Ubuntu 18.0.4
