Implement ID3v2 chapter support #2560
Draft
+220
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
force-pushed
the
implement-id3v2-chapter-support
branch
from
123a300 to
336984b
Compare
gaodeng
reviewed
Jan 7, 2026
| const frames = chap.frames; | ||
| const title = frames.get('TIT2'); | ||
| if (!title) continue; // title is required | ||
| const image = frames.get('APIC'); |
There was a problem hiding this comment.
Suggestion: Support WXXX (User defined URL link frame) in chapter metadata
gaodeng
reviewed
Jan 8, 2026
|
|
||
| const chapter: Chapter = { | ||
| label: util.decodeString(uint8Array.subarray(0, fzero), defaultEnc), | ||
| info: ChapterInfo.get(uint8Array, offset), |
There was a problem hiding this comment.
Should be ChapterInfo. get(uint8Array, fzero + 1) instead of offset. At this point offset is still 0, but ChapterInfo starts after the null-terminated label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imeplement ID3v2 Chapters 1.0 support.
Resolves #2555