Skip to content

Conversation

@Borewit
Copy link
Owner

@Borewit Borewit commented Jan 14, 2026

  • Depend on win-guid for Windows byte order GUID decoding.
  • Replaced custom GUID encode/decode logic with win-guid library functions
  • Renamed GUID class to AsfGuid throughout the codebase

Related to Borewit/file-type-cfbf#16

@Borewit Borewit self-assigned this Jan 14, 2026
@Borewit Borewit added the technical debt Non functional improvements label Jan 14, 2026
@Borewit Borewit requested a review from Copilot January 14, 2026 10:03
@coveralls
Copy link

coveralls commented Jan 14, 2026

Coverage Status

coverage: 95.777% (-0.003%) from 95.78%
when pulling aa66fa8 on use-win-guid
into 81dca61 on master.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the ASF GUID handling by replacing the custom GUID implementation with the external win-guid library. The class is also renamed from GUID to AsfGuid for better consistency with other ASF-related classes.

Changes:

  • Added dependency on win-guid@^0.1.3 package
  • Replaced custom GUID encode/decode logic with win-guid library functions
  • Renamed GUID class to AsfGuid throughout the codebase

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Added win-guid dependency (^0.1.3)
yarn.lock Added win-guid package resolution and checksum
lib/asf/GUID.ts Deleted - custom GUID implementation removed
lib/asf/AsfGuid.ts New file - refactored GUID class using win-guid library
lib/asf/AsfParser.ts Updated imports from GUID to AsfGuid
lib/asf/AsfObject.ts Updated all GUID references to AsfGuid
test/test-file-asf.ts Updated test imports and references to use AsfGuid

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Borewit Borewit marked this pull request as ready for review January 14, 2026 17:04
@Borewit Borewit merged commit b13fab0 into master Jan 14, 2026
7 of 9 checks passed
@Borewit Borewit deleted the use-win-guid branch January 14, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical debt Non functional improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants