Upgrade Laravel and refactor to thin Controllers#448
Draft
nielsdrost7 wants to merge 143 commits into
Draft
Conversation
Migrated from PHP 7.3.9 to PHP 8.2 and updated Laravel framework to version 11.0. Removed `fzaninotto/faker` from development dependencies as it is now deprecated.
The Guzzle HTTP client library has been removed from the composer.json file.
Upgraded "laravel/ui" to "^v4.5.2" and "ramsey/uuid" to "4.7.6". These updates address compatibility and performance improvements.
The laravelcollective/html package was removed from composer.json to streamline dependencies and reduce potential conflicts. Laravel 11 is not currently supported.
Upgraded "yajra/laravel-datatables-oracle" to "^v11.1.5" and "laravel/dusk" to "^8.2.10". These changes aim to maintain compatibility with the latest features and security updates. Adjusted dependencies order for consistency.
Upgraded several dependencies in composer.json to newer versions for improved stability and compatibility. Notable updates include Laravel Tinker, League Flysystem, Mockery, and PHPUnit. Added Laravel Pint to the dev requirements for code style enforcement.
The league/flysystem-cached-adapter package is no longer maintained
Included Laravel Cashier in composer dependencies to support billing. Enhanced script configuration with `post-autoload-dump`, `post-update-cmd`, and `post-create-project-cmd` to streamline setup and development workflow.
The Collective\Html\HtmlServiceProvider has been commented out in the app configuration. This change is likely due to it being no longer required or to resolve a potential issue related to this provider. Other service providers remain unaffected.
The Cashier::ignoreMigrations() method has been removed from the boot method in AppServiceProvider.
Upgraded the elasticsearch/elasticsearch package to version ^8.15.0. Added php-http/discovery as an allowed plugin in the composer configuration to ensure proper package discovery.
Upgraded "predis/predis" to version "^v2.2.2" and "ramsey/uuid" to "^4.7.6". Adjusted "symfony/css-selector" and "symfony/dom-crawler" to version "^7.1.6". These changes ensure compatibility and maintain up-to-date libraries.
Upgraded various development and runtime dependencies to their latest versions. This includes significant updates for tools like laravel-mix, sass, and axios which may offer performance improvements and new features.
The --hide-modules flag was removed from several npm scripts including "dev", "watch", "watch-poll", and "production". This change simplifies the output during the build process by not hiding webpack module details.
Expanded the .env.example file to include additional configuration settings for application, logging, database, session, cache, and mail. This update aligns the .env.example with the new placeholder values.
Updated MySQL to 8.0 and PHP to 8.2 for improved performance and compatibility. Also, upgraded various GitHub Actions to their latest versions to enhance security and functionality. Simplified dependency installation commands.
Added workflow_dispatch trigger to PHPUnit workflow and commented out dependency installation steps.
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d71a91b8-8585-4513-8a1f-9ad8bff88010 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d71a91b8-8585-4513-8a1f-9ad8bff88010 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d71a91b8-8585-4513-8a1f-9ad8bff88010 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d71a91b8-8585-4513-8a1f-9ad8bff88010 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d71a91b8-8585-4513-8a1f-9ad8bff88010 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d71a91b8-8585-4513-8a1f-9ad8bff88010 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d71a91b8-8585-4513-8a1f-9ad8bff88010 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/d46e68b6-a1c6-4182-9344-80e6b138a728 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
…upport Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/321ee8c6-2cd6-455a-af10-9b270e831c16 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/905b991f-99e5-4a88-b1e2-e4297061be39 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/9ea10709-5f74-4425-9988-91af4efe90ca Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/0664f34d-a441-4332-98bb-136290c08bd8 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Co-authored-by: Niels Drost <47660417+nielsdrost7@users.noreply.github.com>
- Fix malformed u# heading in CREATE_FIRST_USER_SUMMARY.md - Add DB::transaction() for atomic admin creation in CreateAdminUser.php - Use RoleType::OWNER->value and Department::MANAGEMENT constant instead of hard-coded strings - Add DEFAULT_LANGUAGE constant for 'en' - Allow ?string in validateInputs() to handle null from ask()/secret() - Update README: safer password example, fix entrust:clear -> entrust:cache-clear - Update CHANGELOG: fix entrust:clear -> entrust:cache-clear, upgrade -> daybyday:upgrade - Rewrite test file: it_ prefix, #[Test] attrs, AAA comments, single DB strategy - Remove mid-test migrate:fresh in both-modes test - Add assertNotNull guards before ->id access on Role/Department - Add Department::MANAGEMENT constant to Department model Agent-Logs-Url: https://github.com/Bottelet/DaybydayCRM/sessions/505ac7f1-1dfb-4341-b4be-5073d6dc4f75 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
* 288: Create command to create first user in the database * 288: ran pint * Change command signature for CreateAdminUser * Rename artisan command from user:create-admin to daybyday:create-admin * Add regression test for no-interaction validation path Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/ed0edc2e-5ef1-4e05-afb1-df5f6bb21cf1 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/13e37f55-824a-43df-b804-132a4aae11a4 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
Add default language constant for admin user command
…eAdminUser command Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/7f001949-60c7-4f61-acb0-d9827b3881e1 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
* Simple Fixes * Clean up Playwright tests * Clean up Playwright tests * quick commit * quick commit * Delete blob-report directory * Improvements * Improvements * Rewrite e2e specs to plain route style Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/3a60d6e7-e3f3-4548-88c9-41cd1dd8e6a5 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix Playwright reporter path Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/3a60d6e7-e3f3-4548-88c9-41cd1dd8e6a5 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix e2e reporter path Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/3a60d6e7-e3f3-4548-88c9-41cd1dd8e6a5 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Harden e2e helper guards Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/3a60d6e7-e3f3-4548-88c9-41cd1dd8e6a5 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Clarify e2e helper failures Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/3a60d6e7-e3f3-4548-88c9-41cd1dd8e6a5 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Remove Playwright blob report Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/3a60d6e7-e3f3-4548-88c9-41cd1dd8e6a5 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Document e2e run workflow Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/aca66e53-37b8-492d-9612-25e3eb97454b Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Clarify e2e script naming Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/aca66e53-37b8-492d-9612-25e3eb97454b Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Remove generated Playwright report Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/aca66e53-37b8-492d-9612-25e3eb97454b Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Clarify single-file e2e docs Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/aca66e53-37b8-492d-9612-25e3eb97454b Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: apply CodeRabbit auto-fixes Fixed 15 file(s) based on 14 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: address remaining e2e review comments Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/ae1d0610-255d-4ddb-b3da-932d00cdfd08 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * chore: remove accidental Playwright blob report artifact Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/ae1d0610-255d-4ddb-b3da-932d00cdfd08 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * test: expand playwright e2e coverage for validation and update flows Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/40e7b58c-2d38-4c79-b73c-417cbacc8515 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * chore: remove accidental playwright blob report artifact Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/40e7b58c-2d38-4c79-b73c-417cbacc8515 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * test: tighten new e2e assertions from review feedback Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/40e7b58c-2d38-4c79-b73c-417cbacc8515 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * test: use field-specific checks in absence and client assertions Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/40e7b58c-2d38-4c79-b73c-417cbacc8515 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * test: make e2e specs sturdy with intent-revealing names, explicit assertions, and full CRUD coverage Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/898ac409-3a5d-466e-9e5d-464a31be2f05 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * chore: remove accidentally committed blob-report and package-lock.json artifacts Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/898ac409-3a5d-466e-9e5d-464a31be2f05 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * feat: add stop-on-failure support for e2e tests and professionalize documentation - Add npm scripts: test:e2e:stop-on-error and test:e2e:stop-on-failure - Add Makefile target: e2e-fail (stop on first failure) - Improve README with organized testing commands section - Professionalize AGENTS.md with detailed e2e workflow documentation - Update .github/copilot-instructions.md with complete e2e command reference - Enhance all .junie/*.md files with structured formatting and comprehensive command examples - Add clear separation between PHPUnit and Playwright testing workflows - Document automatic screenshot/video capture on failure - Include test log locations and failure debugging workflows Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/6cee02bf-021f-491c-9872-9b88fe311a76 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: remove redundant test:e2e:stop-on-error script Keep only test:e2e:stop-on-failure for consistency with PHPUnit naming conventions and to avoid confusion about which command to use. Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/6cee02bf-021f-491c-9872-9b88fe311a76 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * feat: add STOP_ON_FAILURE parameter to Makefile and workflow_dispatch input to GitHub Action - Add STOP_ON_FAILURE parameter to e2e-test and e2e-test-one Makefile targets - Add workflow_dispatch input for stop_on_failure in GitHub Action - Update Makefile help with E2E OPTIONS section and examples - Update all documentation (README, AGENTS.md, copilot-instructions.md, .junie/*.md) with parameter usage examples - Users can now run: make e2e-test STOP_ON_FAILURE=true - GitHub Action now has a checkbox option to stop on first failure when manually triggered Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/d17d2312-1744-44ab-9679-305a2a11b20b Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: apply CodeRabbit auto-fixes Fixed 5 file(s) based on 6 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * test: assert failed login still redirects protected route to login Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/621b1446-32cf-4aa4-85d7-e2aa4bbe51cd Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Add 'develop' branch to Playwright workflow triggers * ci: add richer manual inputs to Playwright workflow Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/f54ed454-8085-47c0-98ca-886ffc457c30 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Improvements for all e2e tests, added more tests * Repaired e2e tests * cleanup * Refactor e2e specs to behavior-first tests Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/29897c76-75d6-4901-bf50-e4f6bea133c4 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Address review feedback in search and invoices specs Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/29897c76-75d6-4901-bf50-e4f6bea133c4 Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: apply CodeRabbit auto-fixes Fixed 8 file(s) based on 5 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai> * Fix e2e specs per PR #45 review feedback Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/01224d76-3c5d-4b41-9f57-563367dc21db Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * Fix Playwright module mismatch and remaining review-driven e2e issues Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/64ee86c6-7f87-4071-b9eb-656482d0ce5a Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: apply CodeRabbit auto-fixes Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai> * fix: apply CodeRabbit auto-fixes Fixed 6 file(s) based on 8 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai> * Apply suggestion from @coderabbitai[bot] Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Apply suggestion from @coderabbitai[bot] Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fix remaining valid e2e review findings in tasks absence and projects specs Agent-Logs-Url: https://github.com/underdogg-forks/DaybydayCRM/sessions/5e6c919c-ef0c-435a-8b27-6eaf2d68c84e Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com> * fix: apply CodeRabbit auto-fixes Fixed 1 file(s) based on 2 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai> * Update playwright.yml * Update Makefile Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: CodeRabbit <noreply@coderabbit.ai> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.