Skip to content

bump rb-sys dependencies#1830

Merged
aaronvg merged 4 commits intocanaryfrom
bump-ruby
Apr 21, 2025
Merged

bump rb-sys dependencies#1830
aaronvg merged 4 commits intocanaryfrom
bump-ruby

Conversation

@aaronvg
Copy link
Copy Markdown
Contributor

@aaronvg aaronvg commented Apr 21, 2025

Important

Bump rb-sys and rb-sys-env dependencies and update GitHub Actions workflow for Ruby build.

  • Dependencies:
    • Bump rb-sys to 0.9.111 in Cargo.lock, Gemfile, and Cargo.toml.
    • Bump rb-sys-env to 0.2.2 in Cargo.lock and Cargo.toml.
  • GitHub Actions:
    • Change branch from aaron-fix to bump-ruby in build-ruby-release.reusable.yaml.
    • Remove x86-64_linux-setup.sh script and related comments in build-ruby-release.reusable.yaml.

This description was created by Ellipsis for 3160ef9. You can customize this summary. It will automatically update as commits are pushed.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 10:20pm

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7a04342 in 1 minute and 4 seconds. Click for details.
  • Reviewed 90 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/language_client_ruby/ext/ruby_ffi/Cargo.toml:25
  • Draft comment:
    The rb-sys dependency bump to 0.9.111 and the corresponding rb-sys-env update to 0.2.2 look correct. Please ensure the features list and the sync with Gemfile remains valid.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. engine/language_client_ruby/ext/ruby_ffi/Cargo.toml:47
  • Draft comment:
    Verified the build-dependency for rb-sys-env is updated. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. engine/language_client_ruby/ext/ruby_ffi/Cargo.toml:25
  • Draft comment:
    rb-sys bumped to 0.9.111. Verify that all listed features (e.g., global-allocator, bindgen-rbimpls, etc.) are still applicable with the new version.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to verify compatibility of features with a new version of a dependency. It falls under the rule of not asking the author to ensure compatibility or verify behavior, which is not allowed.
4. engine/language_client_ruby/ext/ruby_ffi/Cargo.toml:47
  • Draft comment:
    rb-sys-env is updated to 0.2.2 in build-dependencies. Ensure compatibility with the overall build process.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is about a dependency update and suggests ensuring compatibility, which violates the rule against commenting on dependency changes or asking the author to ensure compatibility.
5. .github/workflows/build-ruby-release.reusable.yaml:25
  • Draft comment:
    Typographical error: In the comment on line 25, the phrase "...CentOS 7 which is EOL as of July 2024 Once" appears to be missing punctuation between '2024' and 'Once'. Consider revising this for clarity (e.g., adding a period or comma) to separate the sentences.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_UqJdZ7HoJLTmjLm1

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@aaronvg aaronvg added this pull request to the merge queue Apr 21, 2025
@aaronvg aaronvg removed this pull request from the merge queue due to a manual request Apr 21, 2025
Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 367ac08 in 41 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/language_client_ruby/Gemfile:11
  • Draft comment:
    Bump rb_sys to 0.9.111 - verify sync in Cargo.toml.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is about a dependency change, specifically bumping the version of rb_sys. It asks to verify sync in Cargo.toml, which is related to dependencies. According to the rules, comments on dependency changes should be ignored unless they are about version mismatches or similar issues. This comment does not seem to address a version mismatch or a specific issue, just a general verification request.
2. engine/language_client_ruby/Gemfile:10
  • Draft comment:
    Ensure Cargo.toml is updated to match the new rb_sys version.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is related to dependency management, specifically ensuring that a file is updated to match a new version of a dependency. The rules specify not to comment on dependency changes or library versions that are not recognized. Therefore, this comment should be removed.
3. engine/language_client_ruby/Gemfile:11
  • Draft comment:
    Bump looks correct. Ensure that Cargo.toml is updated to match this exact version.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 20% <= threshold 50% This comment is asking the author to ensure that a dependency file is updated to match a specific version. However, it doesn't specify what version or why this is necessary. It seems to be a general reminder rather than a specific actionable suggestion. It could be considered as asking the author to double-check something, which is against the rules.

Workflow ID: wflow_JSJF6TwzpsGCm0eW

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 3160ef9 in 33 seconds. Click for details.
  • Reviewed 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/language_client_ruby/x86-64_linux-setup.sh:1
  • Draft comment:
    Removed Linux setup script. Confirm intentional removal and update docs/build instructions accordingly, as it installs necessary dependencies for OpenSSL.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. engine/language_client_ruby/x86-64_linux-setup.sh:1
  • Draft comment:
    Script removal: Ensure that any build or documentation references to this setup script are updated accordingly.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_D61ojC2QQm7WbzAo

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@aaronvg aaronvg added this pull request to the merge queue Apr 21, 2025
Merged via the queue into canary with commit 960c7d8 Apr 21, 2025
18 checks passed
@aaronvg aaronvg deleted the bump-ruby branch April 21, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant