fix: cart header layout. - #2
Merged
Merged
Conversation
update from ahmed
Rearrange cart header layout
FrontierSoftech
pushed a commit
to Frontier-Softech/POSNext
that referenced
this pull request
Jan 24, 2026
Issue: - ValidationError: Cannot use Reverse Charge Account in Row BrainWise-DEV#2 since transaction is without Reverse Charge - Tax templates like 'Output GST RCM Out-state - TJCPL' contain both regular and RCM taxes - RCM taxes should only be used when is_reverse_charge = 1 - India Compliance validates this and throws error for normal sales Solution: - Filter out RCM taxes in update_invoice() after loading taxes - Filter out RCM taxes in validate() hook before processing - Filter out RCM taxes in before_save() hook as final check - Exclude RCM templates in get_tax_template_from_category() when auto-detecting RCM Tax Identification: - Uses India Compliance's get_gst_accounts_by_type() to identify RCM accounts - Fallback to pattern matching (account name contains 'RCM') Result: - Normal POS sales now only use regular taxes (IGST, CGST, SGST) - RCM taxes are automatically filtered out - No validation errors - Taxes calculated correctly Files Modified: - pos_next/api/invoices.py: Added RCM filtering after tax loading - pos_next/api/sales_invoice_hooks.py: Added RCM filtering in validate and before_save hooks - pos_next/api/gst_tax.py: Updated to exclude RCM templates in auto-detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.