fix(pos_profile): import cint for allow_credit_sale resolution - #373
Merged
Conversation
get_receivable_accounts calls cint() without importing it, which raises NameError on develop when credit-sale gating runs. This is a real bug fix (F821), not formatting — keep it reviewable on its own. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from frappe.utils import cintinpos_next/api/pos_profile.py.get_receivable_accountsalready callscint(...)at the allow_credit_sale gate; without the import this is a liveNameErroron develop.Why its own PR
Split out of #318's
a4f6ffdruff sweep so this is reviewable as a real bug fix, not formatting. The rest of that sweep was dropped from #318 (N3).Test plan
pos_next.api.pos_profileunder site context (loads clean)get_receivable_accountsfor a profile with POS Settings / credit sale enabled — no NameError[]as beforeMade with Cursor