-
Notifications
You must be signed in to change notification settings - Fork 159
Release 5.18.1 #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.18.1 #1272
Conversation
- v5.18.1 * _*Master Release*_ - May 27, 2025 - Fixes a bug affecting Xiaomi devices. - Fix for rare instances of session parameters getting cleared.
ReferenceSDK-XXX -- Release 5.18.1 Summary By MatterAI
🔄 What Changed
🔍 Impact of the ChangeThis is a minor release that fixes two bugs:
📁 Total Files Changed2 files changed with 8 additions and 2 deletions:
🧪 Test AddedN/A - This is a version release PR that documents bug fixes already implemented and tested. 🔒Security VulnerabilitiesN/A - No security vulnerabilities identified in this version update. Testing InstructionsVerify that the version numbers are correctly updated and the changelog accurately reflects the bug fixes included in this release. Risk Assessment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good overall. It's a straightforward version update with changelog entries for the bug fixes in v5.18.1. I have one suggestion to improve the changelog entry for better clarity.
| - v5.18.1 | ||
| * _*Master Release*_ - May 27, 2025 | ||
| - Fixes a bug affecting Xiaomi devices. | ||
| - Fix for rare instances of session parameters getting cleared. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Code Refactor
Issue: The changelog entry for the Xiaomi device bug fix is quite vague and doesn't provide enough context for users.
Fix: Adding more specific details about the nature of the bug would make the changelog more informative.
Impact: Improves documentation quality and helps users understand exactly what was fixed.
suggestion\n- v5.18.1\n* _*Master Release*_ - May 27, 2025\n - Fixes a bug affecting app initialization on certain Xiaomi device models running MIUI.\n - Fix for rare instances of session parameters getting cleared during background-foreground transitions.\n\n
Reference
SDK-XXX -- <TITLE>.
Description
Testing Instructions
Risk Assessment [
HIGH||MEDIUM||LOW]Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.