Skip to content

Conversation

@gdeluna-branch
Copy link
Contributor

  • v5.18.1
  • Master Release - May 27, 2025
    • Fixes a bug affecting Xiaomi devices.
    • Fix for rare instances of session parameters getting cleared.

Reference

SDK-XXX -- <TITLE>.

Description

Testing Instructions

Risk Assessment [HIGH || MEDIUM || LOW]

  • I, the PR creator, have tested — integration, unit, or otherwise — this code.

Reviewer Checklist (To be checked off by the reviewer only)

  • JIRA Ticket is referenced in PR title.
  • Correctness & Style
    • Conforms to AOSP Style Guides
    • Mission critical pieces are documented in code and out of code as needed.
  • Unit Tests reviewed and test issue sufficiently.
  • Functionality was reviewed in QA independently by another engineer on the team.

cc @BranchMetrics/saas-sdk-devs for visibility.

- v5.18.1
* _*Master Release*_ - May 27, 2025
  - Fixes a bug affecting Xiaomi devices.
  - Fix for rare instances of session parameters getting cleared.
@matter-code-review
Copy link
Contributor

Code Quality bug fix

Reference

SDK-XXX -- Release 5.18.1

Summary By MatterAI MatterAI logo

🔄 What Changed

  • Updated version from 5.18.0 to 5.18.1
  • Updated version code from previous to 052201
  • Added changelog entries for bug fixes in v5.18.1

🔍 Impact of the Change

This is a minor release that fixes two bugs:

  1. A bug affecting Xiaomi devices
  2. Rare instances of session parameters getting cleared

📁 Total Files Changed

2 files changed with 8 additions and 2 deletions:

  • ChangeLog.md: 6 additions, 0 deletions
  • gradle.properties: 2 additions, 2 deletions

🧪 Test Added

N/A - This is a version release PR that documents bug fixes already implemented and tested.

🔒Security Vulnerabilities

N/A - No security vulnerabilities identified in this version update.

Testing Instructions

Verify that the version numbers are correctly updated and the changelog accurately reflects the bug fixes included in this release.

Risk Assessment LOW

This is a documentation and version number update only, with no code changes included in this PR.

  • I, the PR creator, have tested — integration, unit, or otherwise — this code.

Reviewer Checklist (To be checked off by the reviewer only)

  • JIRA Ticket is referenced in PR title.
  • Correctness & Style
    • Conforms to AOSP Style Guides
    • Mission critical pieces are documented in code and out of code as needed.
  • Unit Tests reviewed and test issue sufficiently.
  • Functionality was reviewed in QA independently by another engineer on the team.

cc @BranchMetrics/saas-sdk-devs for visibility.

Tip

Quality Recommendations

  1. Add more specific details about the Xiaomi device bug fix in the changelog

  2. Include information about which Xiaomi devices or Android versions were affected

  3. Provide more context about the session parameters issue that was fixed

Sequence Diagram

sequenceDiagram\n    participant Dev as Developer\n    participant Repo as Branch Android SDK Repository\n    participant CI as CI/CD Pipeline\n    participant Users as SDK Users\n\n    Dev->>Repo: Update VERSION_NAME to 5.18.1\n    Dev->>Repo: Update VERSION_CODE to 052201\n    Dev->>Repo: Add changelog entry for v5.18.1\n    Note over Repo: Bug fixes documented:\n    Note over Repo: - Fix for Xiaomi devices\n    Note over Repo: - Fix for session parameters\n    Repo->>CI: Trigger release build\n    CI->>Users: Publish SDK v5.18.1\n    Users->>Users: Integrate updated SDK\n```
Loading

Copy link
Contributor

@matter-code-review matter-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good overall. It's a straightforward version update with changelog entries for the bug fixes in v5.18.1. I have one suggestion to improve the changelog entry for better clarity.

Comment on lines +2 to +6
- v5.18.1
* _*Master Release*_ - May 27, 2025
- Fixes a bug affecting Xiaomi devices.
- Fix for rare instances of session parameters getting cleared.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Code Refactor

Issue: The changelog entry for the Xiaomi device bug fix is quite vague and doesn't provide enough context for users.
Fix: Adding more specific details about the nature of the bug would make the changelog more informative.
Impact: Improves documentation quality and helps users understand exactly what was fixed.

suggestion\n- v5.18.1\n* _*Master Release*_ - May 27, 2025\n - Fixes a bug affecting app initialization on certain Xiaomi device models running MIUI.\n - Fix for rare instances of session parameters getting cleared during background-foreground transitions.\n\n

@gdeluna-branch gdeluna-branch merged commit d13362c into master May 27, 2025
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants