Added $currency to the content items. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an arguable change because we have currency in the event metadata (`event_data.currency`) for *commerce* events, but no indication of currency in the *content* events. Currently, the content items only have a price with no indication of currency. For consistency of the content items across all events and since we have this field open in EO anyways, I suggest we add it to the docs.
|
once this is supported by Gateway and the Annotator, we can merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an arguable change because we have currency in the event metadata (
event_data.currency) for commerce events, but no indication of currency in the content events.Currently, the content items only have a price with no indication of currency. For consistency of the content items across all events and since we have this field open in EO anyways, I suggest we add it to the docs.
@rubinsingh @Sarkar @dmitrig01 @derrickstaten no objections?