Skip to content

Conversation

@chrisyeagy-branch
Copy link
Collaborator

@chrisyeagy-branch chrisyeagy-branch commented Aug 7, 2025

Description

Editing the build and deployment files to use usw2 s3 buckets.

the temp deployment file was set up to overwrite prod websdk. i added the /websdk/ path we put the staging files in so that it wont do that if accidentally invoked. i am sure whoever works on this again in the future can determine what to do.

i delete release.sh and beta-release.sh because they look to be copied over from the original websdk clone. they would overwrite the websdk (rather than release the connected sdk). so i think its best to remove them before someone does something dumb.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

Copy link

@bredmond5 bredmond5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtb

@chrisyeagy-branch chrisyeagy-branch merged commit dffc9f6 into main Aug 8, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants