Skip to content

Conversation

@bredmond5
Copy link
Contributor

@bredmond5 bredmond5 commented Nov 5, 2024

Pull Request Template

Description

previous pr #1075

I didnt understand that i was supposed to do this before, updated now

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

  1 files  ±0    1 suites  ±0   51s ⏱️ -2s
159 tests ±0  152 ✅ ±0  7 💤 ±0  0 ❌ ±0 
162 runs  ±0  155 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit af55c52. ± Comparison against base commit 41840c9.

♻️ This comment has been updated with latest results.

#!/bin/bash

export AWS_ACCESS_KEY_ID='ID_GOES_HERE'
export AWS_SECRET_ACCESS_KEY='ACCESS_KEY_GOES_HERE'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not how we do aws access keys, so i removed it

CHANGELOG.md Outdated
## [VERSION] - unreleased
## [2.85.1] - 2024-11-04
- Updates qr image download to avoid errors
## [2.85.0] - 2024-02-28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this was released 2024-04-10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops good catch

I didnt understand that i was supposed to do this before, updated now
@bredmond5 bredmond5 merged commit b474851 into master Nov 5, 2024
7 checks passed
@bredmond5 bredmond5 deleted the new-release branch November 5, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants