Skip to content

Conversation

@bredmond5
Copy link
Contributor

Pull Request Template

Description

  1. Make startDev actually work out of the box
  2. Remove the dev/ directory and everything related to that in favor of just using the output dist/
  3. Write proper example.html that is usable in s3 and locally

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

// First Encode array buffer as UTF-8 String, then Base64 Encode
if (this['rawBuffer']) {
const binaryString = Array.from(new Uint8Array(this.rawBuffer))
const binaryString = Array.from(new Uint8Array(rawBuffer))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, here was my bug

@bredmond5 bredmond5 force-pushed the better-dev-experience branch 2 times, most recently from 273f2d6 to 0941189 Compare November 6, 2024 00:17
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Test Results

  1 files  ±0    1 suites  ±0   53s ⏱️ ±0s
159 tests ±0  152 ✅ ±0  7 💤 ±0  0 ❌ ±0 
162 runs  ±0  155 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 273f2d6. ± Comparison against base commit fa7fed4.

@bredmond5 bredmond5 merged commit 0941189 into update-build Nov 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant