Skip to content

Conversation

@bredmond5
Copy link
Contributor

Pull Request Template

Description

I put these to 0.0.0 because i thought it would make it more clear that these come from elsewhere. (we fill these in with the actual gha version when we release). However, some of our apis check the values that we send here. So, having 0.0.0 was breaking some journeys. I put it to 2.85.1. It wont need to be updated unless we make another check on the backend that we want to test

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Results

  1 files  ±0    1 suites  ±0   52s ⏱️ -26s
159 tests ±0  152 ✅ ±0  7 💤 ±0  0 ❌ ±0 
162 runs  ±0  155 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit f8bfff6. ± Comparison against base commit 5459f83.

♻️ This comment has been updated with latest results.

I put these to 0.0.0 because i thought it would make it more clear that these come from elsewhere. (we fill these in with the actual gha version when we release). However, some of our apis check the values that we send here. So, having 0.0.0 was breaking some journeys. I put it to 2.85.1. It wont need to be updated unless we make another check on the backend that we want to test
@bredmond5 bredmond5 merged commit 15c30fa into master Nov 7, 2024
5 checks passed
@bredmond5 bredmond5 deleted the fix-local-dev branch November 8, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants