Skip to content

[patch] try logging into npm #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bredmond5 merged 1 commit into from
Nov 11, 2024
Merged

[patch] try logging into npm #1090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/deploy-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ name: Publish Next Release (Manual)

on:
workflow_dispatch:
inputs:
Copy link
Contributor Author

@bredmond5 bredmond5 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed this in favor of just using the branch passed in

ref:
description: Reference git commit to release (e.g. "master", "12341fa")
required: true
default: master

env:
NODE_VERSION: 18
Expand All @@ -16,8 +11,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.inputs.ref }}

- name: AWS, credentials setup
uses: aws-actions/configure-aws-credentials@v4
Expand All @@ -28,7 +21,7 @@ jobs:

- name: Add INPUT_SHA env var
run: |
export INPUT_SHA=$(git rev-parse ${{ github.event.inputs.ref }})
export INPUT_SHA=$(git rev-parse ${{ github.ref }})
echo "INPUT_SHA=`echo $INPUT_SHA`" >> $GITHUB_ENV

- name: Install branch-github-actions
Expand Down Expand Up @@ -60,6 +53,7 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
registry-url: 'https://registry.npmjs.org'

# Do this before npm configure because it writes the package.json version
- name: Write version to files
Expand Down
Loading