Skip to content

[other] use usw2 for s3 #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisyeagy-branch merged 3 commits into from
Aug 8, 2025
Merged

[other] use usw2 for s3 #1124

chrisyeagy-branch merged 3 commits into from
Aug 8, 2025

Conversation

@chrisyeagy-branch
Copy link
Contributor

@chrisyeagy-branch chrisyeagy-branch commented Aug 7, 2025 •
edited
Loading

Pull Request Template

Description

Change the build files to use the s3 buckets in usw2

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025 •
edited
Loading

Test Results

  1 files  ±0    1 suites  ±0   59s ⏱️ +7s
159 tests ±0  152 ✅ ±0  7 💤 ±0  0 ❌ ±0 
162 runs  ±0  155 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 93443cd. ± Comparison against base commit 58bc816.

♻️ This comment has been updated with latest results.

@matter-code-review
Copy link

matter-code-review bot commented Aug 7, 2025 •
edited
Loading

Code Quality bug fix

Pull Request Template

Description

Summary By MatterAI MatterAI logo

🔄 What Changed

This pull request updates a static asset URL within examples/example.template.html. Specifically, the center_logo_url for the branch-badge-dark.svg image has been changed from an S3 bucket in the us-west-1 region to one in the us-west-2 region (from https://branch-assets.s3.us-west-1.amazonaws.com/branch-badge-dark.svg to https://branch-assets-usw2.s3.us-west-2.amazonaws.com/branch-badge-dark.svg).

🔍 Impact of the Change

This change ensures that the specified logo image is fetched from an S3 bucket located in the us-west-2 AWS region. This can align the asset delivery with other infrastructure components residing in us-west-2, potentially improving regional latency for users or adhering to specific deployment strategies. It is a minor configuration update with no direct impact on core application logic or functionality, only on the source of a static image asset.

📁 Total Files Changed

  • examples/example.template.html: Modified a single URL for an image asset (1 addition, 1 deletion).

🧪 Test Added

No specific tests were added or detailed in the provided PR data. Given the nature of the change (a static URL update in an example HTML file), manual verification of the loaded image in the example template would typically suffice.

  • Unit test: N/A
  • Integration test: N/A

🔒Security Vulnerabilities

No direct security vulnerabilities were introduced by this change. The modification is a change in a static S3 asset URL. Assuming the new us-west-2 S3 bucket has appropriate and secure access policies, this change does not inherently expose new risks.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A - Testing details are not provided in the PR data.

JS Budget Check

N/A - JS budget details are not provided in the PR data.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

N/A

totalScore: 4

Tanka Poem ♫

Region shifts, a new path,
Logo finds its closer home.
Bits now flow with speed,
West-2's cloud, a steady stream,
Data's journey, swift and clean. 🌐✨

Sequence Diagram

sequenceDiagram
    participant Browser as User Browser
    participant WebServer as Web Server
    participant S3_USW2 as S3 (us-west-2)

    Browser->>WebServer: GET /examples/example.template.html
    WebServer-->>Browser: example.template.html content
    Note over Browser: Parses HTML, finds image URL
    Browser->>S3_USW2: GET https://branch-assets-usw2.s3.us-west-2.amazonaws.com/branch-badge-dark.svg
    S3_USW2-->>Browser: branch-badge-dark.svg image
Loading

@matter-code-review
Copy link

matter-code-review bot commented Aug 7, 2025

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

@matter-code-review
Copy link

matter-code-review bot commented Aug 7, 2025

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

@matter-code-review
Copy link

matter-code-review bot commented Aug 7, 2025

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

bredmond5
bredmond5 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@bredmond5 bredmond5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@chrisyeagy-branch chrisyeagy-branch merged commit 34b3814 into main Aug 8, 2025
7 checks passed
@chrisyeagy-branch chrisyeagy-branch deleted the s3-usw2 branch August 8, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bredmond5 bredmond5 bredmond5 approved these changes

@mack-branch mack-branch Awaiting requested review from mack-branch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrisyeagy-branch @bredmond5