[patch] engmt-xx: fix gha #1126
Conversation
|
Pull Request TemplateDescriptionSummary By MatterAI
🔄 What ChangedThis pull request updates two GitHub Actions workflows: 🔍 Impact of the ChangeThe transition to 📁 Total Files Changed
🧪 Test AddedN/A 🔒Security VulnerabilitiesNo new security vulnerabilities were introduced. The removal of explicit AWS access keys from the workflows is a significant security enhancement, improving the overall security posture of the CI/CD pipeline. Type of change
How Has This Been Tested?
JS Budget Check
Checklist:
Mentions:List the person or team responsible for reviewing proposed changes. cc @BranchMetrics/saas-sdk-devs for visibility. Tanka Poem ♫
Sequence DiagramsequenceDiagram
participant G as GitHub
participant R as GHA_Runner (arc-standard-small-set)
participant GH_Repo as GitHub Repository
participant AWS_IAM as AWS IAM Service
Note over G,R: Workflow Triggered (build-push.yml / deploy-release.yml)
G->>R: Assign Job
R->>GH_Repo: actions/checkout@v4 (build-push.yml)
R->>GH_Repo: actions/checkout@v5 (deploy-release.yml)
R->>AWS_IAM: Configure AWS Credentials (aws-actions/configure-aws-credentials@v4)
Note over R,AWS_IAM: Implicit authentication (OIDC/IAM Role)
AWS_IAM-->>R: Temporary Credentials
alt deploy-release.yml specific steps
R->>GH_Repo: git rev-parse ${{ github.ref }}
R->>GH_Repo: actions/checkout@v5 (BranchMetrics/branch-github-actions)
end
alt build-push.yml specific steps
R->>R: Run tests, build
R->>AWS_IAM: Deploy updated builds to staging (if main branch)
end
R-->>G: Job Completion Status
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use MatterAICommand List
|
bredmond5
force-pushed
the
update-gha
branch
2 times, most recently
from
833d7db to
621de96
Compare
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use MatterAICommand List
|
1 similar comment
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use MatterAICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use MatterAICommand List
|
1 participant
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
JS Budget Check
Please mention the size in kb before abd after this PR
Checklist:
Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.