-
Notifications
You must be signed in to change notification settings - Fork 0
DE-159650: Upgrade Elasticsearch dependency to v9.3.0 and update Docker and phpunit config #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,48 +1,51 @@ | ||
| version: '3.4' | ||
|
|
||
| services: | ||
| es01: | ||
| image: &image docker.elastic.co/elasticsearch/elasticsearch:${ES_VERSION:-7.15.2} | ||
| command: &command > | ||
| /bin/sh -c "./bin/elasticsearch-plugin list | grep -q ingest-attachment | ||
| || ./bin/elasticsearch-plugin install --batch ingest-attachment; | ||
| chown elasticsearch /usr/share/elasticsearch/repository; | ||
| /usr/local/bin/docker-entrypoint.sh" | ||
| environment: &environment | ||
| node.name: es01 | ||
| cluster.name: es-docker-cluster | ||
| cluster.initial_master_nodes: es01 | ||
| discovery.seed_hosts: es01 | ||
| bootstrap.memory_lock: 'true' | ||
| ES_JAVA_OPTS: -Xms512m -Xmx512m | ||
| path.repo: /usr/share/elasticsearch/repository | ||
| ulimits: &ulimits | ||
| memlock: | ||
| soft: -1 | ||
| hard: -1 | ||
| volumes: | ||
| - data01:/usr/share/elasticsearch/data | ||
| - esrepo:/usr/share/elasticsearch/repository | ||
| ports: | ||
| - 9200:9200 | ||
| networks: &networks | ||
| - elastic | ||
| es02: | ||
| image: *image | ||
| command: *command | ||
| environment: | ||
| <<: *environment | ||
| node.name: es02 | ||
| ulimits: *ulimits | ||
| volumes: | ||
| - data02:/usr/share/elasticsearch/data | ||
| - esrepo:/usr/share/elasticsearch/repository | ||
| networks: *networks | ||
| es01: | ||
| image: &image docker.elastic.co/elasticsearch/elasticsearch:${ES_VERSION:-9.3.0} | ||
| command: &command > | ||
| /bin/sh -c "./bin/elasticsearch-plugin list | grep -q ingest-attachment | ||
| || ./bin/elasticsearch-plugin install --batch ingest-attachment; | ||
| chown elasticsearch /usr/share/elasticsearch/repository; | ||
| /usr/local/bin/docker-entrypoint.sh" | ||
| environment: &environment | ||
| node.name: es01 | ||
| cluster.name: es-docker-cluster | ||
| cluster.initial_master_nodes: es01 | ||
| discovery.seed_hosts: es01 | ||
| bootstrap.memory_lock: 'true' | ||
| ES_JAVA_OPTS: -Xms512m -Xmx512m | ||
| path.repo: /usr/share/elasticsearch/repository | ||
| xpack.security.enabled: "false" | ||
| xpack.security.transport.ssl.enabled: "false" | ||
| action.destructive_requires_name: "false" | ||
| ulimits: &ulimits | ||
| memlock: | ||
| soft: -1 | ||
| hard: -1 | ||
| volumes: | ||
| - data01:/usr/share/elasticsearch/data | ||
| - esrepo:/usr/share/elasticsearch/repository | ||
| ports: | ||
| - 9200:9200 | ||
| networks: &networks | ||
| - elastic | ||
| es02: | ||
| image: *image | ||
| command: *command | ||
| environment: | ||
| <<: *environment | ||
| node.name: es02 | ||
| ulimits: *ulimits | ||
| volumes: | ||
| - data02:/usr/share/elasticsearch/data | ||
| - esrepo:/usr/share/elasticsearch/repository | ||
| networks: *networks | ||
| volumes: | ||
| data01: | ||
| data02: | ||
| esrepo: | ||
| data01: | ||
| data02: | ||
| esrepo: | ||
|
|
||
| networks: | ||
| elastic: | ||
| driver: bridge | ||
| elastic: | ||
| driver: bridge |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM php:7.2-fpm-alpine | ||
| FROM php:8.1-fpm-alpine | ||
|
|
||
| COPY --from=composer /usr/bin/composer /usr/bin/composer | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,27 +2,27 @@ | |
|
|
||
| <!-- https://phpunit.de/manual/current/en/appendixes.configuration.html --> | ||
| <phpunit | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/8.5/phpunit.xsd" | ||
| colors = "true" | ||
| beStrictAboutOutputDuringTests = "true" | ||
| verbose = "true" | ||
| bootstrap = "vendor/autoload.php" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.5/phpunit.xsd" | ||
| colors = "true" | ||
| beStrictAboutOutputDuringTests = "true" | ||
| verbose = "true" | ||
| bootstrap = "vendor/autoload.php" | ||
|
Comment on lines
+5
to
+10
|
||
| > | ||
| <filter> | ||
| <whitelist> | ||
| <directory>src/</directory> | ||
| <exclude> | ||
| <file>src/Query/Match.php</file> | ||
| </exclude> | ||
| </whitelist> | ||
| </filter> | ||
| <listeners> | ||
| <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/> | ||
| </listeners> | ||
| <testsuites> | ||
| <testsuite name="default"> | ||
| <directory>tests/</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
| <coverage> | ||
| <include> | ||
| <directory>src/</directory> | ||
| </include> | ||
| <exclude> | ||
| <file>src/Query/Match.php</file> | ||
| </exclude> | ||
| </coverage> | ||
| <listeners> | ||
| <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/> | ||
| </listeners> | ||
| <testsuites> | ||
| <testsuite name="default"> | ||
| <directory>tests/</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
| </phpunit> | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
src/Elasticsearch/Endpoints/Update.phpappears to break the codebase:src/Client.phpstill importsElastica\Elasticsearch\Endpoints\Updateand instantiates it inClient::updateDocument(). This will lead to a class-not-found/autoload error unless the client code is updated (e.g., to use the upstreamElasticsearch\Endpoints\Update) or the wrapper is kept.