DE-159650: Update Transport tests for ES v9 and remove dead code after skipped tests#26
Closed
sumitkhopade1986 wants to merge 1 commit intoDE-159650-upgrade-elasticsearch-tests-multi-aggregationfrom
Conversation
…fter markTestSkipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Update Transport tests for ES v9 compatibility and remove unreachable dead code after markTestSkipped calls
Possible impact: tests/Transport/HttpTest.php, tests/Transport/NullTransportTest.php, tests/Transport/GuzzleTest.php
Summary
tests/Transport/HttpTest.php— skips proxy/compression tests incompatible with ES v9 client architecturetests/Transport/NullTransportTest.php— skips functional tests incompatible with v9 NoNodeAvailableExceptiontests/Transport/GuzzleTest.php— removes dead code after markTestSkipped callsStacked PRs (8/9)
DE-159650-upgrade-elasticsearch-tests-multi-aggregation— merge that first.Test Plan
🤖 Generated with Claude Code