On chain check signatures #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonTuretzky
commented
Mar 15, 2025
src/OperatorStateRetriever.sol
Outdated
Comment on lines
280
to
291
| uint32[] memory operatorQuorumBitmapIndices = registryCoordinator | ||
| .getQuorumBitmapIndicesAtBlockNumber(blockNumber, m.operatorIds); | ||
| // check that all operators are registered (this is like the check in getCheckSignaturesIndices, but we check against _signing_ operators) | ||
| for (uint256 i = 0; i < operators.length; i++) { | ||
| uint192 operatorQuorumBitmap = registryCoordinator | ||
| .getQuorumBitmapAtBlockNumberByIndex( | ||
| m.operatorIds[i], | ||
| blockNumber, | ||
| operatorQuorumBitmapIndices[i] | ||
| ); | ||
| require(operatorQuorumBitmap != 0, OperatorNotRegistered()); | ||
| } |
There was a problem hiding this comment.
if it's a view function and they listed operators that are not registered, it's fine , it's a mistake on their end,not sure we should be checking
There was a problem hiding this comment.
This is not a mistake, the BLSSignatureChecker takes in nonSigners because they compute the APK by subtracting the non-signers from the total quorum APK
It really sucks devx wise
(Also if you already comment on mistakes on their end, they should have a utility function to compute the APK of a quorum at a given timestamp)
| } | ||
|
|
||
| // helper function to add two G2 points | ||
| function _addG2Points(BN254.G2Point memory a, BN254.G2Point memory b) |
There was a problem hiding this comment.
does this repo have these functions defined already https://github.com/stevennevins/bls-oracle?
There was a problem hiding this comment.
rubydusa
reviewed
Mar 17, 2025
rubydusa
reviewed
Mar 23, 2025
**Motivation:** Add coverage for with eigenda's contracts **Modifications:** Add tests **Result:** Validate upgrade between m2 state and post slashing state of contracts --------- Co-authored-by: Alex <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.